Firefox 3 beta 5 and context menu [SOLVED]

[nico.pao]

Hi everybody.
I'm using eyeOS with Firefox 3 beta 5 and Ubuntu Hardy.
The problem is the following:
When I right-click the desktop, the firefox context-menu appears over eyeos context-menu.
Is there a way to fix this problem???

[Daniel Gil]

Yes there is. I don't remember exactly how the preferences menu's disposition is in FF3, but at least for FF2 you can disable its context menu going to Preferences->Content tab->clicking Javascript "Advanced" button->Checking the "Disable or replace context menus" option.

My FF is not in english, so the text may be a bit different from the english version, but I don't think it varies too much.

[psychcf]

I really do think that you should add e.preventDefault() to the code...

Code:

document.getElementById("myNode").oncontextmenu=function(e) {
e.preventDefault();
// ...
}

That will prevent the context menu from showing, even if that option is not checked.

[nico.pao]

OK, I was looking for a js command to do it without modifying preferences, and the idea of psychcf seems fine, but how can I easily apply that code to all the HTML elements of eyeOS, making this change persistent during all the eyeOS session??

Thanks

[Lars Knickrehm]

in the file extern/libs/BaseWidgets.js search for "oncontextmenu = function" and add this line after the line you searched for:

Code:

e.preventDefault();

Does that work?

I now tried that myself but it does not work ...

[psychcf]

oh, I forgot you also have to prevent the event from propagating...

here's the full code:

Code:

function onSomething(evt) {
 var isIE = parseFloat(navigator.appVersion.split("MSIE ")[1]) || 0;
 if(isIE) {
  evt = evt || window.event;
  evt.cancelBubble = true;
  evt.returnValue = false;
 }
 else {
  evt.preventDefault();
  evt.stopPropagation();
 }
}

This is from a ticket that I reported, but it was marked as "won't fix"
https://bugs.launchpad.net/eyeos/+bug/219987

[Lars Knickrehm]

Thanks, that works fine !

Here is the correct code for eyeOS:

Serach for

Code:

obj.oncontextmenu = function(e) {

in the file "eyeOSxxxxxxxxxx/extern/libs/eyeWidgets/BaseWidgets.js" and replace that line with these:

Code:

obj.oncontextmenu = function(e) {
if (IEversion > 0) {
e.cancelBubble = true;
e.returnValue = false;
} else {
e.preventDefault();
e.stopPropagation();
}

[nico.pao]

IT WORKS!!!!!!!!

Are you sure that the code added is compatible with other browsers???
If it is, such change should be made avaiable for download as a bugfix for all the user. Don't you agree???

Thanks

[psychcf]

Are you sure that the code added is compatible with other browsers???

Yes, that is 100% cross browser.

[nico.pao]

well, I hope to see this update as soon as possible!!!

Thanks everyboduy